c++ - Figuring out why Word Counter program output is 0 or 1 -

-

i need figure out bug program. when type hello world am, should count number of spaces, keep getting 0 or 1. below full program:

    #include "windows.h"     #include <iostream>     #include <cctype>     using namespace std;      //global declarations.      //function prototypes.     void pause();     void numwords(string&);     int numwords(char []);      int main()     {         string userval;         numwords(userval);         char *constr= new char[userval.length()];         strcpy(constr, userval.c_str()); //string converted c-string.         int fin= numwords(constr);         cout<< "the number of words in sentence "<< fin<< "."<< endl;         delete[] constr;         constr= 0;          pause();         return 0; } /***************************************functions**********************************************************************/ /*1st function pause program.*/ void pause() {     cin.sync();     cin.ignore(); }  /*2nd function ask user input. op*/ void numwords(string &len) {     cout << "please enter sentence , tell how many words has: " << endl;     cin >> len; }  /*3rd function count number of total spaces in sentence.*/ int numwords(char usstr[]) {     int wrdcount= 0,         chrcount= 0,         index= 0;     while(usstr[index]!= '\0')     {         if(isspace(usstr[index]))         {             if(chrcount)             {                 wrdcount++;                 chrcount= 0;             }         }         else             chrcount++;         index++;      }     if(chrcount)         wrdcount++;     return wrdcount; }

can please explain why doesn't count spaces, or if need loop mechanism make work? thank you.

corykramer's suggestion correct. cin stop after first whitespace. if want read whole line, use getline. i've made changes code show renamed function use sentence user. also, don't have convert c-style string work, string works fine.

//function prototypes. void pause(); void getsentence(string&); int numwords(string&);  int main() {     string userval;     getsentence(userval);      int fin = numwords(userval);     cout << "the number of words in sentence " << fin << "." << endl;      pause();     return 0; }  void getsentence(string &len) {     cout << "please enter sentence , tell how many words has: " << endl;     getline(cin, len); }  int numwords(string& usstr) {     int wrdcount = 0,         chrcount = 0,         index = 0;     while(index < usstr.length())     {         ...     }     if(chrcount)         wrdcount++;     return wrdcount; }

you want #include <string>


Comments

Post a Comment

Popular posts from this blog

php - Zend Framework / Skeleton-Application / Composer install issue -

-
i trying create zend framework application using skeleton in netbeans. when run composer install, following error message: "c:\php\php.exe" "c:\composer\composer.phar" "--ansi" "--no-interaction" "update" "--dev" using deprecated option "dev". dev packages installed default now. loading composer repositories package information updating dependencies (including require-dev) requirements not resolved installable set of packages. problem 1 - package requires php >=5.5 php version (5.4.42) not satisfy requirement. problem 2 - installation request zendframework/zendframework 2.5.1 -> satisfiable zendframework/zendframework[2.5.1]. - zendframework/zendframework 2.5.1 requires php >=5.5 -> php version (5.4.42) not satisfy requirement. done. apparently, zend framework only needs php 5.3+ contradicts above. need use php 5.4. my composer.json following: { "name": "
Read more

c# - Better 64-bit byte array hash -

-
i need hash algorithm produces 64-bit hash code ( long ) fewer collisions string.gethashcode() , fast (no expensive calls cryptographic functions). here's implementation of fnv still shows 3% of collisions after testing 2 million random strings. need number way lower. void main() { const string chars = "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz!#@$%^&*()_+}{\":?><,./;'[]0123456789\\"; const int n = 2000000; var random = new random(); var hashes = new hashset<long>(); int collisions = 0; for(int = 0; < n; i++) { var len = random.next(chars.length); var str = new char[len]; (int j = 0; j < len; j++) { str[j] = chars[random.next(chars.length)]; } var s = new string(str); if(!hashes.add(get64bithash( s ))) collisions++; } console.writeline("collision percentage after " + n + " random strings: " + ((doubl
Read more

python - PyCharm Type error Message -

-
i'm newbie trying out ml/dbn in python (3.4) under pycharm (comm.ed 4.5). following definition def make_thetas(xmin,xmax,n): xs = np.linespace(xmin,xmax,n) widths = (xs[1:] - xs[:-1])/2.0 thetas = xs[:-1] + widths return thetas throws error "class 'tuple' not define ' sub ', '-' operator cannot used on instance" on - operator on third line (widths = ....) ideas on how code running under pycharm - works alright in interactive python window. thx. to all, after g'g lot have found workaround seems work within pycharm. workaround because (even python newbie) expected python not need explicit typecasting, not when using datatypes imported lib such numpy. def make_thetas(xmin,xmax,n): xs = np.array(np.linspace(xmin,xmax,n)) widths = (xs[1:] - xs[:-1])/2.0 thetas = xs[:-1]+ widths return thetas using docstrings type-hinting such below did not work def make_thetas(xmin,xmax,n): "&q
Read more