javascript - adding the selected text on the webpage inside a field in an injected sidebar chrome extension when clicked -

-

hi have chrome extension injects sidebar when clicked.what want if select location on webpage , click on extension, automatically fills location input bar selected text , call maps api inside iframe location name query.i have tried using window.getselection().tostring() inside script.js gives me empty string on console log. new chrome extension, not have hang on how the selected text. appreciated. thanks

script.js 

var place;  function handlerequest(request, sender, sendresponse) {     if (request.method == "getselection")        //sendresponse({data: });      if (request.callfunction == "togglesidebar") {           togglesidebar();           console.log("adasda");           place = window.getselection().tostring();     } }  chrome.extension.onrequest.addlistener(handlerequest);  var sidebaropen = false; function togglesidebar() {     if(sidebaropen) {         var el = document.getelementbyid('mysidebar');         el.parentnode.removechild(el);         sidebaropen = false;     }     else {          console.log("hello");         console.log(place);          var sidebar = document.createelement('div');         sidebar.id = "mysidebar";         sidebar.innerhtml = "<form id='addbookmark'><p><label for='title'>" + "location" + "</label><br /></form><input type='text' id='title' name='title' size='20' value='' /></p><p><label for='summary'>" + "description" + "</label><br /></form><p><label for='summary'>" + "image" + "</label><br /><input type='text' id='summary' name='summary' size='20' value='' /></p><input type='text' id='image' name='image' size='20' value='' /><iframe width = '500' height = '310' src='https://www.google.com/maps/embed/v1/place?key=aizasycpkknjmevis7cvjvilgad83vl5igu_dfc&q=singapore' allowfullscreen></iframe><div id='dropbox' ondrop='drop(event);' ondragover='return false' ><img id ='myimage' style = 'max-width:300px;max-height:300px' src = ''></div>";  //      '\ //          <h1>hello</h1>\ //          <form id=" '+ addbookmark + '">\ //          ';          sidebar.style.csstext = "\             position:fixed;\             top:0px;\             right:0px;\             width:23%;\             height:70%;\             background:white;\             box-shadow:inset 0 0 1em black;\             z-index:999999;\         ";          document.body.appendchild(sidebar);         sidebaropen = true;     } }   var dropbox = document.getelementbyid('dropbox'); dropbox.addeventlistener('drop', drop, false);   function drop(evt) {     evt.stoppropagation();     evt.preventdefault();      var imageurl = evt.datatransfer.getdata('url'); <!--    alert(imageurl)-->     document.getelementbyid('myimage').src = imageurl; }

background.html

    <script type="text/javascript" src="background.js"></script>

background.js

console.log( 'background.html starting!' ); /*put page action icon on tabs*/ chrome.tabs.onupdated.addlistener(     function(tabid) {             chrome.pageaction.show(tabid);         });  chrome.tabs.getselected(null, function(tab) {     chrome.pageaction.show(tab.id); });  /*send request current tab when page action clicked*/ chrome.pageaction.onclicked.addlistener(     function(tab) {         chrome.tabs.getselected(null, function(tab) {             chrome.tabs.sendrequest(                 //selected tab id                 tab.id,                 //params inside object data                 {method : "getselection",                 callfunction: "togglesidebar"},                  //optional callback function                 function(response) {                     console.log(response.data);                 }             );         });     } );  var place = window.getselection().tostring()  console.log( 'background.html done.' );

manifest.json

{     "name": "inject sidebar",     "manifest_version": 2,     "description": "inject sidebar on current tab when page action clicked",     "version": "0.2",     "background": {         "page": "background.html"     },     "page_action": {         "default_icon": "icon.png",         "default_title": "inject sidebar"     },     "content_scripts": [         {             "matches": ["<all_urls>"],             "js": ["script.js"]         }     ],     "permissions": [         "tabs"     ] }

i have seen problems in code.

background.js

var place = window.getselection().tostring() should not placed here. can't have selected text in background page. can remove line.

like said in comment, should replace depracated chrome.tabs.getselected chrome.tabs.query({active: true}, callback);, read more function here.

script.js

the smelling code handlerequest function. have made condition, first doing nothing, , second, if have understood, displaying sidebar.

so think problem here. should move place = window.getselection().tostring(); statement first condition , call sendresponse({data : place}). way, should send text selected in page background script.

function handlerequest(request, sender, sendresponse) {     if (request.method == "getselection")     {        place = window.getselection().tostring();        console.log("sending background : " + place);        sendresponse({data: place});     }      if (request.callfunction == "togglesidebar")     {        togglesidebar();        console.log("adasda");     } }

all code

you should clean up. there lot of not usefull comment should remove. improve readability of code better debuging.


Comments

Post a Comment

Popular posts from this blog

c# - Better 64-bit byte array hash -

-
i need hash algorithm produces 64-bit hash code ( long ) fewer collisions string.gethashcode() , fast (no expensive calls cryptographic functions). here's implementation of fnv still shows 3% of collisions after testing 2 million random strings. need number way lower. void main() { const string chars = "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz!#@$%^&*()_+}{\":?><,./;'[]0123456789\\"; const int n = 2000000; var random = new random(); var hashes = new hashset<long>(); int collisions = 0; for(int = 0; < n; i++) { var len = random.next(chars.length); var str = new char[len]; (int j = 0; j < len; j++) { str[j] = chars[random.next(chars.length)]; } var s = new string(str); if(!hashes.add(get64bithash( s ))) collisions++; } console.writeline("collision percentage after " + n + " random strings: " + ((doubl
Read more

webrtc - Which ICE candidate am I using and why? -

-
[questions in bold below] i have setup kurento media server 5.1.3 in datacenter behind firewall running os ubuntu 14.04. has 2 network cards: 222.222.222.222 (eth0 - private ip) 111.111.111.111 (eth1 - public ip) attached below sdp (setremotedescription) when browser connected kurento media server type: answer, sdp: v=0 o=- 5487318114793304426 0 in ip4 0.0.0.0 s=kurento media server c=in ip4 0.0.0.0 t=0 0 a=group:bundle audio video m=audio 59068 rtp/savpf 111 0 c=in ip4 111.111.111.111 a=rtpmap:111 opus/48000/2 a=rtpmap:0 pcmu/8000 a=sendrecv a=rtcp:59068 in ip4 111.111.111.111 a=rtcp-mux a=ssrc:669011897 cname:user39019747@host-6e83e4c2 a=extmap:3 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time a=mid:audio b=as:20 a=ice-ufrag:ymdk a=ice-pwd:lylifk5ueqzpwm91ddj37e a=fingerprint:sha-256 ff:0f:81:8c:41:4e:b4:b6:c6:d8:36:f3:d6:5f:09:fd:5f:af:13:b3:9d:fc:12:66:ac:f3:56:d6:5b:0a:73:5d a=candidate:1 1 udp 2013266431 111.111.111.111 55239 typ host a=candidate:2 1 udp
Read more

php - Zend Framework / Skeleton-Application / Composer install issue -

-
i trying create zend framework application using skeleton in netbeans. when run composer install, following error message: "c:\php\php.exe" "c:\composer\composer.phar" "--ansi" "--no-interaction" "update" "--dev" using deprecated option "dev". dev packages installed default now. loading composer repositories package information updating dependencies (including require-dev) requirements not resolved installable set of packages. problem 1 - package requires php >=5.5 php version (5.4.42) not satisfy requirement. problem 2 - installation request zendframework/zendframework 2.5.1 -> satisfiable zendframework/zendframework[2.5.1]. - zendframework/zendframework 2.5.1 requires php >=5.5 -> php version (5.4.42) not satisfy requirement. done. apparently, zend framework only needs php 5.3+ contradicts above. need use php 5.4. my composer.json following: { "name": "
Read more